Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing Font Awesome css #286

Closed
BradMcDanel opened this issue Jun 1, 2017 · 3 comments
Closed

Importing Font Awesome css #286

BradMcDanel opened this issue Jun 1, 2017 · 3 comments

Comments

@BradMcDanel
Copy link

I am trying to extend Razzle to handle font awesome. Font awesome requires a ?v= as part of the path (as discussed here: facebook/create-react-app#295). Razzle appears to break in the same way discussed in that issue when trying to import font-awesome.css. It seems the fix is to add regex to the loader (facebook/create-react-app#298 (diff)).

Just for reference, I am working off of the with-typescript example project. Thanks.

@jaredpalmer
Copy link
Owner

So it looks like all we need to do is add that extra regex to the url loader and we are good to go

@jaredpalmer
Copy link
Owner

Can you test out master to see if this is solved with new url loader setup?

@jaredpalmer
Copy link
Owner

Fixed here: e1a374b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants