Require branches to be up to date before merging

[atugushev]

What's the problem this feature will solve?

Currently, the master might be broken by merging a PR that has not been tested with the latest code. I believe we could adjust the repository settings to avoid this issue.

Describe the solution you'd like

Update the repository settings to protect the master branch:

Additional context

#824 (comment)

[atugushev]

kindly ping @jezdez

[jezdez]

@atugushev which of the status check should be required to be passing (as mentioned in the help text to the "Require branches to be up to date before merging")?

Status checks found in the last week for this repository:
codecov/patch
codecov/project
continuous-integration/appveyor/branch
continuous-integration/appveyor/pr
continuous-integration/travis-ci
coverage/coveralls
test (2.7, pipmaster, ubuntu-latest)
test (2.7, pipmaster, windows-latest)
test (3.5, pipmaster, ubuntu-latest)
test (3.5, pipmaster, windows-latest)
test (3.6, pipmaster, ubuntu-latest)
test (3.6, pipmaster, windows-latest)
test (3.7, pipmaster, ubuntu-latest)
test (3.7, pipmaster, windows-latest)
test (3.8, pipmaster, ubuntu-latest)
test (3.8, pipmaster, windows-latest)

[atugushev]

@jezdez I wouldn't require any of that, because the coverage could be decreased or tests failed (canceled for example) for any unimportant reason and it could be inappropriate to block merge on that.

[jezdez]

The feature requires enabling at least one:

[atugushev]

Okay... Let's try these two then:

• continuous-integration/appveyor/pr
• continuous-integration/travis-ci

[altendky]

For GitHub Actions I add an all job that depends on the others so I can select a single item for the GitHub actions builds. This way when you change matrixing, or even just job names, you don't have to update your GitHub branch policies. Also, depending on other selections admins can override these conditions on the PR page when merging. But yeah, if GitHub Actions isn't primary then this is a side-note FYI.

https:/pytest-dev/pytest-twisted/blob/7cf213bacf37240995b8d6bb46cf90935b05f2fd/.github/workflows/ci.yml#L120-L130

  all:
    name: All
    runs-on: ubuntu-latest
    needs:
      - test
      - linting
    steps:
      - name: This
        shell: python
        run: |
          import this

[jezdez]

@atugushev Done.

[atugushev]

@altendky thanks for the trick! GitHub Actions CI is on the way.

@jezdez thank you!