Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xfail test_realistic_complex_sub_dependencies on pypy windows #1148

Closed
atugushev opened this issue May 17, 2020 · 4 comments · Fixed by #1489
Closed

Xfail test_realistic_complex_sub_dependencies on pypy windows #1148

atugushev opened this issue May 17, 2020 · 4 comments · Fixed by #1489
Labels
good first issue A good item for first time contributors to work on tests Testing and related things

Comments

@atugushev
Copy link
Member

atugushev commented May 17, 2020 •
edited
Loading 

      # TODO: fix test_realistic_complex_sub_dependencies test on Windows

this could be an xfailing test

Originally posted by @webknjaz in #1147 (comment)
@atugushev atugushev added good first issue A good item for first time contributors to work on tests Testing and related things labels May 17, 2020
@atugushev atugushev mentioned this issue May 17, 2020
Merged
@DiddiLeija
Copy link
Contributor

Hi @atugushev. Is this issue resolved? If not, I can work on it. Just tell me where to go.

@atugushev
Copy link
Member Author

Hello @DiddiLeija,

It's not yet resolved. This test should be marked as xfail for the Windows platform so that we can uncomment the Windows platform on CI.

@DiddiLeija
Copy link
Contributor

Ok. I'll be opening a PR the next week.

@DiddiLeija DiddiLeija mentioned this issue Sep 26, 2021
Merged
4 tasks
@DiddiLeija
Copy link
Contributor

I created #1489 to fix this issue.

@AndydeCleyre AndydeCleyre mentioned this issue May 25, 2022
Merged
4 tasks
AndydeCleyre added a commit to AndydeCleyre/pip-tools that referenced this issue May 31, 2022
@AndydeCleyre
Expect success for pypy test affected by jazzband#1148
084d2bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good item for first time contributors to work on tests Testing and related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Xfail test_realistic_complex_sub_dependencies on PyPy under Windows DiddiLeija/pip-tools
2 participants
@atugushev @DiddiLeija