Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: pip-sync --dry-run should return a non-zero exit code if changes were to occur #1166

Closed
graingert opened this issue Jun 26, 2020 · 6 comments · Fixed by #1172
Closed
Assignees
Labels
cli Related to command line interface things enhancement Improvements to functionality feature Request for a new feature

Comments

@graingert
Copy link
Member

What's the problem this feature will solve?

I'm looking to add a pre-commit hook to check the environment is up to date

-   repo: local
    hooks:
    -   id: pip-sync
        name: pip-sync check
        entry: pip-sync --dry-run
        language: system
        always_run: true
        pass_filenames: false

Describe the solution you'd like

$ pip-sync --dry-run
Would install:
  numpy==1.18.5
$ $?
2

Alternative Solutions

various | awk stuff

Additional context

NA

@atugushev atugushev added feature Request for a new feature cli Related to command line interface things labels Jun 28, 2020
@francisbrito
Copy link
Contributor

Hello @atugushev, @graingert. Is this change being worked on already? If not, is it OK if I write a PR for this feature?

@atugushev
Copy link
Member

Hello @francisbrito,

Feel free to pick this up 👍

@atugushev atugushev added the enhancement Improvements to functionality label Jul 2, 2020
@atugushev
Copy link
Member

Hello @graingert,

That sounds reasonable! Thanks for the issue.

@francisbrito
Copy link
Contributor

Hello @atugushev,

Just a quick heads-up: the PR for this is #1172. Please let me know if you have any comments regarding it.

@graingert
Copy link
Member Author

Amazing thanks @francisbrito and @atugushev !

@francisbrito
Copy link
Contributor

You're welcome @graingert. Thanks for the opportunity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to command line interface things enhancement Improvements to functionality feature Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants