Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-sync ignores options in requirements.txt #638

Closed
kmontag opened this issue Feb 22, 2018 · 4 comments · Fixed by #824
Closed

pip-sync ignores options in requirements.txt #638

kmontag opened this issue Feb 22, 2018 · 4 comments · Fixed by #824
Assignees
Labels
enhancement Improvements to functionality PR wanted Feature is discussed or bug is confirmed, PR needed

Comments

@kmontag
Copy link

kmontag commented Feb 22, 2018

Same issue as #367, just re-opening because it seems discussion there isn't getting noticed.

Options like --index-url and --extra-index-url are honored when passed explicitly to pip-sync, but ignored when they're included in requirements.txt. So something like this:

# requirements.in
--extra-index-url https://my.private.index/
private-package==1.0.0

will compile successfully (via pip-compile requirements.in) to:

# requirements.txt
--extra-index-url https://my.private.index/
private-package==1.0.0

but then pip-sync requirements.txt will throw Could not find a version that satisfies the requirement private-package==1.0.0.

This can obviously be worked around with pip-sync --extra-index-url https://my.private.index/ requirements.txt, but pip-sync should be able to recognize the option automatically.

@davidovich
Copy link
Contributor

Thanks for the issue. We will welcome any PR that can fix this problem that you are having, in the pure open-source fashion :-)

@davidovich davidovich added the PR wanted Feature is discussed or bug is confirmed, PR needed label Feb 22, 2018
@desaintmartin
Copy link

Hey, this looks interesting in adding one handy feature of pip into pip-tools. How can we go further with this? I think #674 is a good start.

@suutari-ai
Copy link
Contributor

There's also my earlier PR #464 which addresses this same issue, I think.

estan pushed a commit to estan/pip-tools that referenced this issue Dec 31, 2018
This adds support in pip-sync for

    --no-index
    -i, --index-url <url>
    --extra-index-url <url>
    -f, --find-links <url>
    --process-dependency-links
    --no-binary <format_control>
    --only-binary <format_control>
    --pre
    --trusted-host <hostname>

in the input requirements.txt files.

Closes jazzband#637
Closes jazzband#638
@atugushev atugushev added the enhancement Improvements to functionality label Sep 19, 2019
@atugushev
Copy link
Member

atugushev commented Oct 19, 2019

I've prepared a pull request (#824), which adds support of --index-url/--extra-index-url and the other options. Any feedback, review/test would be appreciated!

@atugushev atugushev self-assigned this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality PR wanted Feature is discussed or bug is confirmed, PR needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants