Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pip>=20.0 support #1024

Merged
merged 7 commits into from
Jan 18, 2020
Merged

Add pip>=20.0 support #1024

merged 7 commits into from
Jan 18, 2020

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Dec 28, 2019 •
edited
Loading

Release tracking issue: pypa/pip#7531

Changelog-friendly one-liner: Add pip>=20.0 support

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev mentioned this pull request Dec 28, 2019
Closed
@codecov
Copy link

codecov bot commented Dec 28, 2019 •
edited
Loading

Codecov Report

Merging #1024 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
+ Coverage   99.11%   99.32%   +0.21%     
==========================================
  Files          34       34              
  Lines        2364     2371       +7     
  Branches      303      305       +2     
==========================================
+ Hits         2343     2355      +12     
+ Misses         11        8       -3     
+ Partials       10        8       -2
Impacted Files Coverage Δ
piptools/repositories/pypi.py 95.6% <100%> (+2.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da08e5...9d1afa2. Read the comment docs.

@atugushev atugushev added this to the 4.4.0 milestone Dec 28, 2019
@atugushev atugushev added the enhancement Improvements to functionality label Dec 28, 2019
atugushev referenced this pull request Dec 31, 2019
@atugushev
Move require_hashes to Resolver._resolve_one()
10a2dcb 
See: pypa/pip#7068
@atugushev atugushev marked this pull request as ready for review January 12, 2020 17:08
@atugushev atugushev changed the title WIP: Add pip>=20.0 support Add pip>=20.0 support Jan 12, 2020
@atugushev
Copy link
Member Author

@codingjoe @vphilippon it's ready to review. The release is gonna be soon.

codingjoe
codingjoe approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😵 sooo many pip versions. But looks good.

@atugushev
Copy link
Member Author

atugushev commented Jan 18, 2020 •
edited
Loading

The CI is still green, so it's ready to merge. A few days left to pip's release. Thanks, @codingjoe, for reviewing this!

@atugushev atugushev merged commit e6bdde4 into jazzband:master Jan 18, 2020
@atugushev atugushev deleted the pip-20.0 branch January 18, 2020 03:51
@atugushev
Copy link
Member Author

pip-tools v4.4.0 is released!

@replaceafill replaceafill mentioned this pull request Feb 28, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingjoe codingjoe codingjoe approved these changes

@vphilippon vphilippon Awaiting requested review from vphilippon

Assignees
No one assigned
Labels
enhancement Improvements to functionality
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@atugushev @codingjoe