Remove six dependency in favor pip's vendored six #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
added
refactor
Allows removing a dependency of pip-tools. The package is already guaranteed to exist within pip, so might as well use it. As more and more projects are dropping Python 2 support, they too are dropping six as a dependency. As more projects drop six, this will eventually remove the need for projects to pull in six as a transient dependency. When pip eventually drops Python 2 support, it will also drop six. When that day comes, pip-tools can also drop Python 2 support, so the eventual lack of six should not be an issue.
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows removing a dependency of pip-tools. The package is already
guaranteed to exist within pip, so might as well use it.
As more and more projects are dropping Python 2 support, they too are
dropping six as a dependency. As more projects drop six, this will
eventually remove the need for projects to pull in six as a transient
dependency.
When pip eventually drops Python 2 support, it will also drop six. When
that day comes, pip-tools can also drop Python 2 support, so the
eventual lack of six should not be an issue.
Contributor checklist