-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt user to use the backtracking resolver on errors #1719
Conversation
Looks like I'm missing a couple of tests here to get good enough coverage. I'll work on that a little, but it might take me a small while to figure out how to do that. |
Let me help you with a mininal test. Setup the following dummy packages and prepare wheels on
|
Thanks for the hints! |
Not sure what to do about the macos test failure. It's a failure in an unrelated test (I think?) so it's probably safe to ignore in this context. Not sure what's happening with the lack of test coverage though. Tox reports the same locally too. This test https:/jazzband/pip-tools/pull/1719/files#diff-99b06d953a9978ee564df2e67547b8a76f3b1ab116ab7c89a9005b9239f2a904R2492 should certainly be hitting the new code. It passes when run in isolation:
And there is no indication that it's failing here either. Is it just not running during the coverage check or something? |
It's unrelated to your PR. See #1720 for details. |
Combine tests
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot! 🎉
Thanks very much for your hand holding with this! |
Prompt the user to use the backtracking resolver if the legacy resolver is in use and pip-tools is failing to resolve the dependencies. This is as mentioned in #1717 and related to PR #1718.
Contributor checklist
Maintainer checklist
backwards incompatible
,feature
,enhancement
,deprecation
,bug
,dependency
,docs
orskip-changelog
as they determine changelog listing.