Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed strange (updating-requirements)= from README.md #2084

Closed
wants to merge 1 commit into from

Conversation

denisSurkov
Copy link

Removed strange (updating-requirements)=

Contributor checklist
  • Included tests for the changes.
  • PR title is short, clear, and ready to be included in the user-facing changelog.
Maintainer checklist
  • Verified one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Removed strange (updating-requirements)=
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's MyST, it should be there.

@WhyNotHugo
Copy link
Member

It doesn't look like the README is rendered with MyST. The string (updating-requirements)= is just rendered as a regular paragraph on GitHub.

@webknjaz
Copy link
Member

webknjaz commented May 6, 2024

Yep. GitHub uses its own flavor — GFM. But this document is also used in Sphinx. GH is known for breaking rendering, though (they recently broke RST even more than before..). So I don't really care about this. I think it's better to have nicer docs on RTD where we have full control over the markup. That includes the changelog (which is currently isn't even displayed there, I think).

One way to solve this would be to remove most of the README and link the Sphinx docs but that would remove the ability to see so much content on the GH repo front page.

@denisSurkov
Copy link
Author

Well, that's true. @webknjaz , sorry I didn't check it beforehand. I'll close PR.

https://pip-tools.readthedocs.io/en/stable/#updating-requirements

no strange string in docs

@denisSurkov denisSurkov closed this May 6, 2024
@denisSurkov denisSurkov deleted the patch-1 branch May 6, 2024 14:09
@webknjaz
Copy link
Member

webknjaz commented May 6, 2024

FTR this is something to be discussed, clearly. And if someone would like to offer different opinions and implementation suggestions, I won't be in a way. Of course, it'll mean taking on more maintenance responsibility in this specific area of the project.
I just wanted to document why things are as they are today so that it could be taken into account in the future. Not many people were involved in plugging in Sphinx and then MyST so it may not be obvious to an average contributor.

@WhyNotHugo
Copy link
Member

I wasn't aware the sphinx was including the README. Thanks for your clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants