Fixed bug breaking pip-sync on Python 3, raising TypeError #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Moved and renamed
resolver._dep_key
toutils.key_from_ireq
and use itfor the
InstallRequirement
s sort insync.sync
.In the future, we might want to change calls like
key_from_req(ireq.req)
tokey_from_ireq(ireq)
, but I'll keep thechange to a minimum here for this bugfix before doing additional tests.
Contributor checklist