Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to allow enabling/disabling build isolation #758

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

atugushev
Copy link
Member

Closes #721.

Changelog-friendly one-liner: Add an option to allow enabling/disabling build isolation

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test should be enhanced.

tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
Co-Authored-By: atugushev <[email protected]>
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #758 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   91.94%   91.97%   +0.03%     
==========================================
  Files          35       35              
  Lines        2296     2305       +9     
  Branches      306      307       +1     
==========================================
+ Hits         2111     2120       +9     
  Misses        153      153              
  Partials       32       32
Impacted Files Coverage Δ
piptools/repositories/pypi.py 89.15% <100%> (+0.06%) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
piptools/scripts/compile.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf6afc...4ab052f. Read the comment docs.

@atugushev atugushev force-pushed the build-isolation branch 2 times, most recently from 1e6be1f to 9fddce6 Compare March 7, 2019 18:45
@jkp
Copy link

jkp commented Mar 11, 2019

Will this get merged?

@atugushev atugushev merged commit 25ac090 into jazzband:master Mar 11, 2019
@atugushev atugushev added the enhancement Improvements to functionality label Mar 11, 2019
@atugushev
Copy link
Member Author

pip-tools v3.5.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants