Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show less output on sync with quiet option #765

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Mar 19, 2019

Doesn't show "Everything up-to-date" if quiet option is set.

Changelog-friendly one-liner: Show less output on sync with quiet option

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the enhancement Improvements to functionality label Mar 19, 2019
@atugushev atugushev requested a review from blueyed March 19, 2019 04:20
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #765 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   91.99%   92.03%   +0.03%     
==========================================
  Files          35       35              
  Lines        2311     2322      +11     
  Branches      307      308       +1     
==========================================
+ Hits         2126     2137      +11     
  Misses        153      153              
  Partials       32       32
Impacted Files Coverage Δ
tests/test_sync.py 100% <100%> (ø) ⬆️
tests/test_cli_sync.py 100% <100%> (ø) ⬆️
piptools/sync.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de11ae...118c6ec. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #765 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   91.99%   92.03%   +0.03%     
==========================================
  Files          35       35              
  Lines        2311     2322      +11     
  Branches      307      308       +1     
==========================================
+ Hits         2126     2137      +11     
  Misses        153      153              
  Partials       32       32
Impacted Files Coverage Δ
tests/test_sync.py 100% <100%> (ø) ⬆️
tests/test_cli_sync.py 100% <100%> (ø) ⬆️
piptools/sync.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de11ae...118c6ec. Read the comment docs.

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@atugushev atugushev added this to the 3.6.0 milestone Mar 19, 2019
@atugushev atugushev merged commit bc28e36 into jazzband:master Mar 19, 2019
@atugushev
Copy link
Member Author

@blueyed thanks!

@atugushev
Copy link
Member Author

pip-tools v3.6.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants