fix: add wagtail-modeladmin as dependency #470
Conversation
according to the contribute guidelines, I've added myself to the list
There was a problem hiding this comment.
Thanks for the PR, @JanMalte!
wagtail-modeladmin is already listed as a development-extra requirement. Could you remove it from there? It's doesn't make sense to have it listed twice...
(PS I saw the tests failed... but I don't think it's due to your PR. It's already late over here, so I'm going to give it a better look tomorrow)
|
When I prepared #461 I didn’t add the new non-contrib version of ModelAdmin as a deployment requirement because if an older version of Wagtail was being used you would end up with both the contrib and non-contrib versions loaded; it seemed that delegating that choice to the developer made sense, and the installation documentation aligns with this. Before hard-coding non-contrib ModelAdmin as a deployment requirement, it should be tested against pre-5.1 versions of Wagtail. By February 2024 Wagtail 4.1 LTS will go out of support (see https://endoflife.date/wagtail) so I suggest that is the time to add non-contrib ModelAdmin as a deployment requirement, maybe as a minor or major release. |
this is just a quick fix for #459
The project should migrate to use wagtail snippets instead.