Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒: add bandit code scanner #479

Merged
merged 1 commit into from
Feb 26, 2024
Merged

🔒: add bandit code scanner #479

merged 1 commit into from
Feb 26, 2024

Conversation

schlich
Copy link
Contributor

@schlich schlich commented Feb 21, 2024

GitHub security suggests a code scanner, I think bandit is fine.

add bandit scanner
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@MrCordeiro MrCordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR!
I'm guessing the workflow was auto-generated, as some of the comments seem superfluous (lines 1-11). But I don't think it's deal-breaker, we can trim those later.

Feel free to rebase and merge when you can!

@schlich
Copy link
Contributor Author

schlich commented Feb 21, 2024

@MrCordeiro can you confirm we want a rebase here? Since master's HEAD is a direct descendant of this branch's HEAD, I think a merge commit would give us less headaches, but i'm not familiar with the nuances of GitHub's "rebase and merge" button. I usually reserve rebasing for updating feature branches if master HEAD is not a descendant of feature branch HEAD.

Let me know if I'm missing something... rebasing makes me more nervous than merging to main 😅

@MrCordeiro
Copy link
Contributor

No problems, do what you feel more comfortable with. 😉

(For context: the rebase strategy is good for avoiding the extra commit that's created by the default merge strategy. Btw, since this PR consists of a single commit, a squash merge would achieve the same result.)

@MrCordeiro MrCordeiro merged commit 3d8cd6a into master Feb 26, 2024
13 checks passed
@MrCordeiro MrCordeiro deleted the bandit-action branch February 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants