Use webfactory/phumbor instead of 99designs/phumbor #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `99designs/phumbor` library has been unmaintained for a long time. In particular, there is a long-standing issue regarding application of `rawurlencode()` to image URLs (99designs/phumbor#20) which has not been addressed. Also the (direct question whether the code is still maintained or not)[99designs/phumbor#30] has not been answered for almost a year. In order to address the URL encoding issue, I forked the original repo: * https:/webfactory/phumbor/ * https://packagist.org/packages/webfactory/phumbor With this change I would like to suggest switching this bundle over to the forked library.
|
/notify @MalteWunsch |
|
Strange because https:/99designs seems to still have a lot of activities but you are right, nothing for the past years on this library. I am going to merge it and revert in case they merge the url encoding part later. |
|
Thank you @jbouzekri |
|
Released 2.0.0 |
|
Disregard. You just tagged it :-) 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
99designs/phumborlibrary has been unmaintained for a long time. In particular, there is a long-standing issue regarding application ofrawurlencode()to image URLs (99designs/phumbor#20) which has not been addressed. Also the direct question whether the code is still maintained or not has not been answered for almost a year.In order to address the URL encoding issue, I forked the original repo:
With this change I would like to suggest switching this bundle over to the forked library.