Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8, update packages, fix unit tests to be culture-invariant #44

Merged
merged 7 commits into from
Sep 28, 2024

Conversation

jeffijoe
Copy link
Owner

@jeffijoe jeffijoe commented Sep 28, 2024

Includes changes from and closes #37, closes #38, closes #39, closes #43

Frooxius and others added 7 commits September 28, 2024 18:35
Source generators must use NetStandard 2.0 as per documentation. Having .NET 6 and .NetStandard 2.1 included has been causing VS2022 to load the wrong version and not run the source generator properly
@jeffijoe
Copy link
Owner Author

@Airex @Frooxius I've included changes from both your PRs here since I had merged another one and didn't want to make you rebase 😅 Thanks!

@jeffijoe jeffijoe merged commit 13ce061 into master Sep 28, 2024
1 check passed
@jeffijoe jeffijoe deleted the net8 branch September 28, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants