Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update settings style #114

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Update settings style #114

merged 2 commits into from
Jul 20, 2020

Conversation

thornbill
Copy link
Member

  • Updates the settings screen to better conform to iOS design standards.
    • List Items use a lighter background color
    • Uses colored text (clear) button styles
  • Fixes inconsistent spacing when a section does not include a header

Before:
IMG_4169

After:
IMG_4168

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anthonylavado anthonylavado merged commit 51974d0 into jellyfin:master Jul 20, 2020
@thornbill thornbill deleted the update-settings-style branch December 8, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonylavado anthonylavado anthonylavado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Jellyfin Mobile for iOS - Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thornbill @anthonylavado