Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HomeScreen and fix pull to refresh #119

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Refactor HomeScreen and fix pull to refresh #119

merged 2 commits into from
Jul 24, 2020

Conversation

thornbill
Copy link
Member

  • Refactor HomeScreen into multiple components
  • Moves logic for managing rotation lock state and hiding the status bar to App component
  • Adds action() calls to functions that modify mobx state: https://mobx.js.org/refguide/action.html
  • Adds isFullscreen to root mobx store
  • Fixes buginess with pull to refresh (especially for Android)

This ended up being larger than expected and didn't even address the issue I started out looking at. 🙊

Fixes #9

@anthonylavado anthonylavado self-requested a review July 22, 2020 20:25
@thornbill thornbill mentioned this pull request Jul 22, 2020
Merged
dkanada
dkanada reviewed Jul 23, 2020
View reviewed changes
constants/Colors.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anthonylavado anthonylavado merged commit 18dc84a into jellyfin:master Jul 24, 2020
@thornbill thornbill deleted the refactor-home-screen branch July 24, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkanada dkanada dkanada left review comments

@anthonylavado anthonylavado anthonylavado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Jellyfin Mobile for iOS - Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull to refresh webview is buggy
3 participants
@thornbill @anthonylavado @dkanada