Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor validator #182

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Refactor validator #182

merged 4 commits into from
Dec 14, 2020

Conversation

thornbill
Copy link
Member

  • Renames JellyfinValidator => ServerValidator
  • Changes ServerValidator from a class to just directly exporting functions since it has no state

camc314
camc314 reviewed Dec 9, 2020
View reviewed changes
utils/ServerValidator.js Outdated Show resolved Hide resolved
utils/ServerValidator.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

camc314
camc314 approved these changes Dec 11, 2020
View reviewed changes
utils/ServerValidator.js Show resolved Hide resolved
@thornbill thornbill merged commit ef392e3 into jellyfin:master Dec 14, 2020
@thornbill thornbill deleted the refactor-validator branch December 14, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Jellyfin Mobile for iOS - Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thornbill @camc314