Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout issues on error screen for notch iPhones #201

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Dec 30, 2020

Similar to #190 but for the error screen.

Also the screen was not honoring the left/right insets due to the absolute positioning being used. Changing to mode='margin' fixed that.

Before:
3E9B9472-2CE9-4930-8CBB-16870CE44D6A

After:
AED8DC85-AE1E-4761-AF4C-5FE00E1E746C

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit d2bdb7e into jellyfin:master Dec 30, 2020
@thornbill thornbill deleted the error-screen-notch branch December 30, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants