Add check for server info before checking version #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
force-pushed
the
fix-missing-version
branch
from
7a16800
to
ce31a8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 28.46% 28.46%
=======================================
Files 31 31
Lines 657 657
Branches 132 133 +1
=======================================
Hits 187 187
+ Misses 427 426 -1
- Partials 43 44 +1
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed.
|
anthonylavado
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the server info is not available immediately after adding a server. The compare versions function throws an exception if it is provided
nullinstead of a string.