Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compact height check to util #245

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

thornbill
Copy link
Member

Moves the isCompact check to a utility function to allow for code reuse.

@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.6% 8.6% Duplication

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #245 (64b28d4) into master (e88e264) will increase coverage by 0.25%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   33.58%   33.83%   +0.25%     
==========================================
  Files          33       33              
  Lines         658      659       +1     
  Branches      133      134       +1     
==========================================
+ Hits          221      223       +2     
+ Misses        394      393       -1     
  Partials       43       43              
Impacted Files Coverage Δ
components/ErrorView.js 0.00% <0.00%> (ø)
utils/Device.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88e264...64b28d4. Read the comment docs.

@anthonylavado anthonylavado merged commit 225e99b into jellyfin:master Apr 4, 2021
@thornbill thornbill deleted the is-compact-check branch April 5, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants