Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help modal to add server screen #246

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Apr 5, 2021

Adds a help icon to the add server screen that opens a modal when pressed.

Add Server Screen Help Modal
27962761-9E75-4F45-978B-CC60276F4994 A63484A9-CDE1-4B91-A224-32F8C3BD615B

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.8% 7.8% Duplication

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #246 (997cd99) into master (225e99b) will decrease coverage by 0.93%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   33.68%   32.74%   -0.94%     
==========================================
  Files          33       36       +3     
  Lines         662      681      +19     
  Branches      133      134       +1     
==========================================
  Hits          223      223              
- Misses        397      416      +19     
  Partials       42       42              
Impacted Files Coverage Δ
App.js 0.00% <ø> (ø)
constants/Links.js 0.00% <0.00%> (ø)
navigation/RootNavigator.js 0.00% <0.00%> (ø)
screens/AddServerScreen.js 0.00% <0.00%> (ø)
screens/ServerHelpScreen.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 225e99b...997cd99. Read the comment docs.

@anthonylavado anthonylavado merged commit ab2134a into jellyfin:master Apr 6, 2021
@thornbill thornbill deleted the server-help-modal branch April 6, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants