Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate setting screen sections for playback and appearance #248

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Apr 5, 2021

Adds separate section in the settings screen for Playback and Appearance options.

Screenshot

4CC6C330-9F78-4613-8C02-244393CB4396

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #248 (980084c) into master (804b0e1) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   33.09%   32.76%   -0.34%     
==========================================
  Files          37       37              
  Lines         692      699       +7     
  Branches      137      138       +1     
==========================================
  Hits          229      229              
- Misses        420      425       +5     
- Partials       43       45       +2     
Impacted Files Coverage Δ
screens/SettingsScreen.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804b0e1...980084c. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

@thornbill thornbill marked this pull request as ready for review April 6, 2021 14:01
@anthonylavado anthonylavado merged commit 5032395 into jellyfin:master Apr 6, 2021
@thornbill thornbill deleted the add-setting-sections branch April 6, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants