Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated device id #312

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

thornbill
Copy link
Member

Removes the deprecated usage of Expo's device id constant and replaces it with a randomly generated id in the root store.

Depends on #311

@thornbill thornbill added the enhancement New feature or request label Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #312 (5e1291a) into master (1b427cb) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   33.00%   33.19%   +0.19%     
==========================================
  Files          37       37              
  Lines         703      705       +2     
  Branches      139      139              
==========================================
+ Hits          232      234       +2     
  Misses        425      425              
  Partials       46       46              
Impacted Files Coverage Δ
components/NativeShellWebView.js 0.00% <ø> (ø)
stores/RootStore.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b427cb...5e1291a. Read the comment docs.

@thornbill thornbill changed the title Remove device Remove deprecated device id Oct 19, 2021
@thornbill thornbill mentioned this pull request Oct 19, 2021
@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Oct 23, 2021
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Oct 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill marked this pull request as ready for review October 26, 2021 14:54
@thornbill thornbill merged commit c97dda0 into jellyfin:master Oct 27, 2021
@thornbill thornbill deleted the remove-device-id branch October 27, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants