Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add even more component tests #325

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Nov 16, 2021

Adds tests for ServerInput, NativeShellWebView, and VideoPlayer.

I can divide this into multiple PRs if this is too much to review.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #325 (d2a9671) into master (5ce2c13) will increase coverage by 10.97%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #325       +/-   ##
===========================================
+ Coverage   37.77%   48.75%   +10.97%     
===========================================
  Files          39       39               
  Lines         720      724        +4     
  Branches      144      145        +1     
===========================================
+ Hits          272      353       +81     
+ Misses        402      334       -68     
+ Partials       46       37        -9     
Impacted Files Coverage Δ
components/ServerInput.js 100.00% <100.00%> (+100.00%) ⬆️
components/NativeShellWebView.js 17.91% <0.00%> (+17.91%) ⬆️
components/VideoPlayer.js 25.39% <0.00%> (+25.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce2c13...d2a9671. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@thornbill thornbill changed the title Add more component tests Add even more component tests Nov 22, 2021
@thornbill thornbill marked this pull request as ready for review November 22, 2021 18:32
@anthonylavado anthonylavado merged commit ed13982 into jellyfin:master Nov 26, 2021
@thornbill thornbill deleted the even-moar-component-tests branch November 27, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants