Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fetch with timeout to separate utility #353

Merged
merged 2 commits into from
Mar 26, 2022

Conversation

thornbill
Copy link
Member

Moves the fetch with timeout functionality to a dedicated utility function for future reuse

@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Mar 23, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #353 (92d5413) into master (5606893) will increase coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   48.26%   48.75%   +0.49%     
==========================================
  Files          39       40       +1     
  Lines         719      722       +3     
  Branches      143      143              
==========================================
+ Hits          347      352       +5     
+ Misses        335      333       -2     
  Partials       37       37              
Impacted Files Coverage Δ
utils/Fetch.js 100.00% <100.00%> (ø)
utils/ServerValidator.js 100.00% <100.00%> (+4.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@anthonylavado anthonylavado merged commit e37946c into jellyfin:master Mar 26, 2022
@thornbill thornbill deleted the refactor-fetch-timeout branch March 26, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
Development

Successfully merging this pull request may close these issues.

2 participants