Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookmarklet use #111

Open
ddupas opened this issue Nov 15, 2022 · 2 comments
Open

bookmarklet use #111

ddupas opened this issue Nov 15, 2022 · 2 comments

Comments

@ddupas
Copy link

ddupas commented Nov 15, 2022

in order to use the bookmarklet we had to make some minor modifications, thought you might like to see that, i would of rather been able to import the bookmarklet with a crossorigin script tag and avoided maintaining this file (minor issue) ;) thank you for the bookmarklet

https:/ddupas/msfish/blob/main/bookmarklet.js

@jenil
Copy link
Owner

jenil commented Nov 15, 2022

@ddupas thanks, can you make a PR?

@ddupas
Copy link
Author

ddupas commented Nov 20, 2022

instead of the bookmarklet js file in the root of the project i created a submodule and linked the project as a submodule
pull request:
#112
submodule:
https:/ddupas/swatchpicker

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants