Fixing jenkinsci#216: partial logs not showing colors #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #216. At least it does for my setup. But now the test hudson.plugins.ansicolor.ColorConsoleAnnotatorTest#testNoGlobalPipelineColorMap is failing and I do not fully understand about the mechanism behind.
Problem seems to be a mixture of a missing pipeline step log line which could define the color map name in combination with partial / progressive output. Whenever there is no log line originated from a pipeline step rendered before the first ANSI escape sequence, the color map stays null and the log lines are not converted to (colorful) HTML. This often happens when a lot of colorful logs are written between to pipeline log lines or no pipeline log line at all.
I thought it could be worth providing this PR even though the mentioned test is failing. I hope this can help to start a discussion and I can bring it towards a useful and sustainable fix.