Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of commons-beanutils. #4328

Closed
wants to merge 1 commit into from

Conversation

jeffret-b
Copy link
Contributor

Pick up the latest improvements and hardenings. Minor update. We don't use the affected features but it would be good to be on the latest version.

I don't think this one warrants a Jira ticket, but I can create one if it helps.

No new tests are needed as there should be no changes. Relying on existing tests and compilation for regression detection. The update from 1.9.3 to 1.9.4 should not have an impact.

See the commons-beanutils changelog or the PR

Proposed changelog entries

  • Internal: Update commons-beanutils from 1.9.3 to 1.9.4.

Submitter checklist

  • [n/a] JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Pick up the latest improvements and hardenings. Minor update.
Copy link
Contributor

@res0nance res0nance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Assuming CI Passes

@res0nance res0nance added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Oct 29, 2019
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 not tested manually, but read the changelog.

@jeffret-b
Copy link
Contributor Author

Let's try a rebuild and see if we can get a clean one now.

@jeffret-b jeffret-b closed this Nov 1, 2019
@jeffret-b jeffret-b reopened this Nov 1, 2019
@jeffret-b
Copy link
Contributor Author

Hmm ... I need to investigate the test failures. See if they're because of my change or the Jenkins CI infra.

@jeffret-b jeffret-b added the on-hold This pull request depends on another event/release, and it cannot be merged right now label Nov 2, 2019
@jeffret-b
Copy link
Contributor Author

This turned out to be more difficult than originally believed. The changes I proposed are insufficient and not necessarily the way we want to proceed. We should consider the technical debt of our Jelly release before proceeding in that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold This pull request depends on another event/release, and it cannot be merged right now rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants