Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of Prototype from OpenStack Cloud #363

Closed
basil opened this issue May 18, 2023 · 4 comments · Fixed by #369
Closed

Remove usages of Prototype from OpenStack Cloud #363

basil opened this issue May 18, 2023 · 4 comments · Fixed by #369

Comments

@basil
Copy link
Member

basil commented May 18, 2023

See this blog post for details. Prototype will eventually be removed from Jenkins core. To prepare for this transition, this plugin must be migrated away from Prototype. The blog post contains instructions on how to find and eliminate usages of Prototype. In this plugin, the following usages of Prototype have been identified. This may not be an exhaustive list:

./plugin/src/main/resources/jenkins/plugins/openstack/compute/JCloudsCloud/computerSet.jelly:23:
new Ajax.Request("${rootURL}/cloud/"+item.value.cloud+"/provision", {

CC @olivergondza

@basil
Copy link
Member Author

basil commented Jun 29, 2023

@olivergondza Gentle ping. The replacement of this Ajax.Request usage with a call to fetch() should be simple to develop and test. Without this fix, this plugin will break when Jenkins core eventually removes Prototype.js.

@basil
Copy link
Member Author

basil commented Jul 24, 2023

@olivergondza Gentle ping

@olivergondza
Copy link
Member

@basil, thanks for the issues and for the Fix. Merged with a slight amendment.

@basil
Copy link
Member Author

basil commented Jul 27, 2023

Thanks! Can this please be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants