Update SlackUploadFileStep help-channel to use channel ID instead of … #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…channel name to fix misleading docs issue
timja
requested changes
Aug 13, 2024
There was a problem hiding this comment.
This isn't correct, whilst channel ids will be more efficient channel names are supported just fine:
https:/jenkinsci/slack-plugin/blob/master/src/main/java/jenkins/plugins/slack/cache/SlackChannelIdCache.java#L69
|
Ok, I thought it would support both. But tried many times. Only id worked. Neither channel-name nor #channel-name was able to work. I had a look at the source code. Yes some support codes were there. But no result. Maybe this is a bug. Let me check it out again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…channel name to fix misleading docs issue
Testing done
Submitter checklist