Support WorkflowJob (Pipeline) jobs #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to support WorkflowJob (Pipeline) job types. The WorkflowJob implements BuildableItem and ParameterizedJobMixin.ParameterizedJob interface, but is not an AbstractProject type.
davidstaheli
approved these changes
Feb 15, 2017
| @@ -54,6 +56,7 @@ | |||
| private static final Map<String, AbstractCommand.Factory> COMMAND_FACTORIES_BY_NAME; | |||
| public static final String URL_NAME = "team-build"; | |||
| public static final String PARAMETER = "parameter"; | |||
| public static final String BUILD_SOURCE_BRANCH = "Build.SourceBranch"; | |||
There was a problem hiding this comment.
Do you know if Build.SourceBranch is available in VSTS Release Management scenarios? If not, can we handle its absence gracefully?
There was a problem hiding this comment.
Great call. Made changes to get the branch from:
- jobName input.
- Build.SourceBranch variable
Throw if none of them are available.
We will try parse the branch name in this order:
1. Parse the branch name if job name is in format of ${multibranch pipeline}/${branch}
2. Read Build.SourceBranch variable
davidstaheli
approved these changes
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when triggering a Pipeline job, we will get a "Project not found" exception as
WorkflowJobis not ofAbstractProjecttype.All information the plugin requires can be retrieved by
BuildableItemandParameterizedJobMixin.ParameterizedJobinterface, andWorkflowJobimplements both interfaces. The change is to explicitly cast bothAbstractProjectandWorkflowJobdown toBuildableItemandParameterizedJobMixin.ParameterizedJoband pass it around as such.