Adding basic telemetry to the plugin #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Incoming events from TFS are covered - Other events like change in status or labeling sources
jeffyoung
approved these changes
Jun 23, 2017
| private static final String SYS_PROP_USER_NAME = "user.name"; | ||
| private static final String SYS_PROP_JAVA_RUNTIME = "java.runtime.name"; | ||
| private static final String SYS_PROP_JAVA_VERSION = "java.version"; | ||
| private static final String USER_AGENT_FORMAT = "{0}/{1} {2}/{3} {4}/{5} {6}/{7} ({9})"; |
There was a problem hiding this comment.
Good catch! 9 should be 8.
|
I agree. There are probably a lot more places we need telemetry. I just wasn't sure where those other places were. This initial telemetry is mostly a guess on the places I think are most interesting. I could be way off. As for error conditions, I just don't know which "catches" are exceptional yet and which aren't :( |
jeffyoung
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This telemetry will be sent to Application Insights for tracking what features users are engaged with.