[JENKINS-73894] Un-inline JavaScript in IssuesChartPortlet/portlet.jelly #1859
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
=========================================
Coverage 82.57% 82.57%
Complexity 1360 1360
=========================================
Files 249 249
Lines 5233 5233
Branches 402 402
=========================================
Hits 4321 4321
Misses 802 802
Partials 110 110 ☔ View full report in Codecov by Sentry. |
yaroslavafenkin
commented
Oct 11, 2024
| } | ||
| </script> | ||
| <st:bind value="${it}" var="trendProxy"/> | ||
| <f:invisibleEntry> |
There was a problem hiding this comment.
I think this could be changed to have inline style on the span hiding the element if someone is opposed to the current approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-73894
Makes the plugin a step closer to being CSP compatible.
Testing done
I've installed https://plugins.jenkins.io/dashboard-view/ plugin so that I can reach the code in question. Created a new dashboard view, and in Portlets at the top of the page section I've added Static analysis issues chart. I've not spent time setting up a project that would have actual violations, so my issues chart is empty.
https://www.loom.com/share/9ed2252e9eda40e4a17e8e745757fe18?sid=e90705e4-c41c-4b35-9a20-0bf361676310
https://www.loom.com/share/7a2a6a2cab2d428f8aa8a3af873174a0?sid=8cee3380-af6b-44eb-aff7-a352d126c549
Submitter checklist
Link to relevant pull requests, esp. upstream and downstream changes