Check the given path in process.readSource #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment is not about this PR. Why we expose |
galpeter
reviewed
Dec 8, 2017
src/modules/iotjs_module_process.c
Outdated
| @@ -142,6 +142,14 @@ JS_FUNCTION(ReadSource) { | |||
| DJS_CHECK_ARGS(1, string); | |||
|
|
|||
| iotjs_string_t path = JS_GET_ARG(0, string); | |||
|
|
|||
| struct stat path_stat; | |||
| stat(iotjs_string_data(&path), &path_stat); | |||
There was a problem hiding this comment.
Shouldn't we use the libtuv's stat call here?
The path argument in the process.readSource must point to an existing file, not a directory. Fix #1351 IoT.js-DCO-1.0-Signed-off-by: Imre Kiss [email protected]
|
So, I've updated the PR based on @galpeter review. @glistening please take a look to it. |
|
Still LGTM. ( @galpeter, thank you for comment. ) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path argument in the process.readSource must point
to an existing file, not a directory.
Fix #1351
IoT.js-DCO-1.0-Signed-off-by: Imre Kiss [email protected]