Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve default test results focus behavior #1128

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

connectdotz
Copy link
Collaborator

This is to change the default test results panel focusing behavior for auto-run modes (watch, on-save) when no "testing.openTesting" and "jest.outputConfig" is defined. While there is an easy workaround, it has nevertheless interrupted users' workflow. This fix should eliminate the root cause; thus, no workaround will be needed anymore.

This PR introduce different default behavior by run-mode:

  • For watch and on-save, when nothing is defined (the default), test results panel will not auto switch focus.
  • For on-demand, when nothing is defined (the default), test results panel will auto switch focus. => same as v6.2.2

Also removed the auto-run mode warning since it is no longer needed.

This is to improve the following issues further:

@coveralls
Copy link

coveralls commented Mar 15, 2024

Pull Request Test Coverage Report for Build 8301826188

Details

  • 43 of 43 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 98.005%

Totals Coverage Status
Change from base Build 8268417093: 0.007%
Covered Lines: 3928
Relevant Lines: 3935

💛 - Coveralls

@connectdotz connectdotz merged commit 0d3bf2a into jest-community:master Mar 15, 2024
11 checks passed
@connectdotz connectdotz deleted the default-test-results branch March 15, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants