Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equinox shipping : container finalization process manager #56

Merged
merged 44 commits into from
Apr 10, 2020

Conversation

Kimserey
Copy link
Contributor

@Kimserey Kimserey commented Mar 11, 2020

Equinox implementation of a process manager managing the finalization of a container within the context of shipments being packed into a container.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@bartelink bartelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, lots of picky comments coz me ;)

dotnet-templates.sln Outdated Show resolved Hide resolved
equinox-shipment/Domain/Container.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Container.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Container.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Container.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Shipment.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Shipment.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Shipment.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Shipment.fs Outdated Show resolved Hide resolved
equinox-shipment/Domain/Shipment.fs Outdated Show resolved Hide resolved
@bartelink bartelink changed the base branch from master to shipping April 8, 2020 18:47
module Events =

type Event =
| Finalized
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kimserey we could make this event bear the Assigned shipmentIds in order to exemplify that the process manager can shuttle state across aggregates ...

IRL, does the list of proposed shipmentIds accumulate on the Aggregate, or is it something that's managed by some external agent / UI ?

@bartelink bartelink marked this pull request as ready for review April 10, 2020 10:14
@bartelink bartelink merged commit 8886c9c into jet:shipping Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants