Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proCosmosReactor for same Container Reactions #93

Merged
merged 22 commits into from
Sep 13, 2021

Conversation

ragiano215
Copy link
Contributor

@ragiano215 ragiano215 commented Jul 22, 2021

Adding a new template: proCosmosReactor that is a stripped down derivative of the Propulsion Reactor template for a simpler exposition for:

  • demonstrating usage against just Cosmos
  • command processing is stripped down to use a single container both for listening and writing events to (the full template requires the monitored and target container to be specified separately, even if you're using the same Container for both)

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021

CLA assistant check
All committers have signed the CLA.

@bartelink
Copy link
Collaborator

template name (and an overview as to the motivation!) should go in the overview - PR title and/or commit when it gets merged should be <60 chars
Also needs to be added to the readme.md (inc putting it in the walkthrough) and the changelog.md

@ragiano215 ragiano215 changed the title Template for Same Cosmos Source-Destination Container Propulsion Reactor Added proCosmosReactor Template for Same Container Reaction Aug 8, 2021
README.md Outdated Show resolved Hide resolved
@ragiano215 ragiano215 marked this pull request as ready for review August 14, 2021 12:58
@bartelink bartelink changed the title Added proCosmosReactor Template for Same Container Reaction Add proCosmosReactor for same Container Reactions Aug 14, 2021
@bartelink
Copy link
Collaborator

Thanks for your contribution (and bearing with all the nitpicking)!

@bartelink bartelink merged commit 8ea8e6e into jet:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants