Skip to content

Commit

Permalink
Update Readme (facebook#14176)
Browse files Browse the repository at this point in the history
Replace core with react, dom-client with react-dom
  • Loading branch information
mmarkelov authored and jetoneza committed Jan 23, 2019
1 parent 44a5ca8 commit 8a68c0c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fixtures/unstable-async/suspense/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Follow these steps:
# 1: Build react from source
cd /path/to/react
yarn
yarn build dom-client,core,react-cache,scheduler --type=NODE
yarn build react-dom/index,react/index,react-cache,scheduler --type=NODE

# 2: Install fixture dependencies
cd fixtures/unstable-async/suspense/
Expand Down
2 changes: 1 addition & 1 deletion fixtures/unstable-async/time-slicing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ There are also known bugs and inefficiencies in master so **don't use this fixtu
# 1: Build react from source
cd /path/to/react
yarn
yarn build dom-client,core,react-cache,scheduler --type=NODE
yarn build react-dom/index,react/index,react-cache,scheduler --type=NODE

# 2: Install fixture dependencies
cd fixtures/unstable-async/time-slicing/
Expand Down
2 changes: 1 addition & 1 deletion scripts/bench/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
In most cases, the only two commands you might want to use are:

- `yarn start`
- `yarn --cwd=../../ build core,dom-client --type=UMD_PROD && yarn start --skip-build`
- `yarn --cwd=../../ build react/index,react-dom/index --type=UMD_PROD && yarn start --skip-build`

The first command will run benchmarks with all the default settings. A local and remote build will occur on React and ReactDOM UMD bundles, both local and remote repos will be run against all benchmarks.

Expand Down
2 changes: 1 addition & 1 deletion scripts/bench/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ async function buildBenchmarkBundlesFromGitRepo(
async function buildReactBundles(reactPath = getDefaultReactPath(), skipBuild) {
if (!skipBuild) {
await executeCommand(
`cd ${reactPath} && yarn && yarn build core,dom-client --type=UMD_PROD`
`cd ${reactPath} && yarn && yarn build react/index,react-dom/index --type=UMD_PROD`
);
}
}
Expand Down

0 comments on commit 8a68c0c

Please sign in to comment.