Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with NaN values in PolarPlots #410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SamKry
Copy link

@SamKry SamKry commented Jul 10, 2024

proposal fix for issue #409

respects NaN values and skips them

Open for discussion: What should happen with "connect first and last point" feature? Now it just connects the first and last non-NaN points (which could be misleading). Please just open a new issue for that and assign it to me if you would want to have this changed.

@SamKry SamKry changed the title Fix issue with NaN values in PolarPlots closes #409 Fix issue with NaN values in PolarPlots Jul 10, 2024
@trashgod
Copy link
Contributor

I'm wary of silently ignoring NaN values by default. Would this feature see broader acceptance as a mutable property?

@SamKry
Copy link
Author

SamKry commented Aug 7, 2024

I've updated the PR so that there is now a mutable property called hideNaNValues in DefaultPolarItemRenderer which controlls the handling of NaN values in Polar plots. (see discussion in issue #409 )

Additionally if connectFirstAndLastPoint is enabled, the new property is respected too. If hideNaNValues is enabled, it only connects the first and last point of they are not NaN, else a gap will be drawn.

hideNaNValues is set to false by default so that the default behavior is the same as before.

@trashgod
Copy link
Contributor

For reference, this branch can be tested in a local clone, as shown here:

git clone https:/jfree/jfreechart.git temp
pushd temp
git fetch origin pull/410/head:fix-NaN-values-in-PolarPlots
git branch --list
git checkout fix-NaN-values-in-PolarPlots
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants