Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #2730

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix integration tests #2730

merged 2 commits into from
Oct 22, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 20, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Update the tests to align with changes introduced in Artifactory 7.90+:

  • REST APIs to http://127.0.0.1:8081/access are no longer functional. Instead, use http://127.0.0.1:8082/access.
  • The archive indexing feature has been completely removed, meaning we cannot test this feature in the newer versions of Artifactory. In this pull request, the archive indexing tests have been entirely removed.
  • Make the Access tests to run locally.

Additionally, in this pull request, the access tests are now executed locally on 127.0.0.1 instead of the SaaS server.

@yahavi yahavi added the ignore for release Automatically generated release notes label Oct 20, 2024
@yahavi yahavi self-assigned this Oct 20, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 20, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 20, 2024
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 21, 2024
@yahavi yahavi changed the title Fix Access tests Fix integration tests Oct 21, 2024
@yahavi yahavi marked this pull request as ready for review October 22, 2024 08:46
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the removal of the archive indexing also means that the below flag no longer works from a specific version of Artifactory.
If this is the case, let's also add the following prefix to the flag's description -

This option stopped being supported since version XXX for Artifactory.
(replace XXX with the right version).
Let's also update the online documentation with that description.

archiveEntries: cli.StringFlag{
		Name:  archiveEntries,
		Usage: "[Optional] If specified, only archive artifacts containing entries matching this pattern are matched. You can use wildcards to specify multiple artifacts.` `",
	},

access_test.go Outdated Show resolved Hide resolved
@yahavi yahavi merged commit cb22362 into jfrog:dev Oct 22, 2024
13 of 14 checks passed
@yahavi yahavi deleted the fix-access-tests branch October 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants