refactor & sonar fixes #1472
Merged
refactor & sonar fixes #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion & introduced "explaining variable"
…oappU_KSf&resolved=false&types=CODE_SMELL&id=jhipster-framework&open=AYQzN3fW2_PoappU_KSh sonar fix: https://sonarcloud.io/project/issues?fileUuids=AYQzN3Lt2_PoappU_KSf&resolved=false&types=CODE_SMELL&id=jhipster-framework&open=AYQzN3fW2_PoappU_KSj sonar fix: https://sonarcloud.io/project/issues?fileUuids=AYQzN3Lt2_PoappU_KSf&resolved=false&types=CODE_SMELL&id=jhipster-framework&open=AYQzN3fW2_PoappU_KSk
|
Hi @DanielFran 
Build and all tests is passing locally
but few checks are failing in CI pipeline
can you kindly guide? |
|
@DishaAnand closed/reopen to see if cache issue is resolved |
DanielFran
requested changes
Nov 21, 2023
jhipster-framework/src/main/java/tech/jhipster/web/util/HeaderUtil.java
Outdated
Show resolved
Hide resolved
…ge in HeaderUtil" This reverts commit e8a85b3.
|
Hi @DanielFran I have pushed the changes Thank you ! : ) |
DanielFran
requested changes
Nov 22, 2023
jhipster-framework/src/main/java/tech/jhipster/async/ExceptionHandlingAsyncTaskExecutor.java
Outdated
Show resolved
Hide resolved
jhipster-framework/src/main/java/tech/jhipster/config/liquibase/AsyncSpringLiquibase.java
Outdated
Show resolved
Hide resolved
- added version for ExceptionHandlingAsyncTaskExecutor file - removed unwanted character
|
Hi @DanielFran I have made the suggested changes. KIndly have a look! |
DanielFran
approved these changes
Nov 22, 2023
|
Thanks @DishaAnand for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:Sonar Issue Id:Refactored Files:Lint File:Test File: