Improve error logging #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People have been finding it hard to diagnose where errors come from because the promises would swallow them. I've added some logging around places where Marty calls into user code, namely: - Store#handleAction: We log the store, action handler, error and action - StateMixin#getState: We log the view and error - when: We log the fetch, store and error - ActionCreator: We log the action type, action, action creator and error Resolves #127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have been finding it hard to diagnose where errors come from
because the promises would swallow them. I've added some logging around
places where Marty calls into user code, namely:
Store#handleAction: We log the store, action handler, error and actionStateMixin#getState: We log the view and errorwhen: We log the fetch, store and errorActionCreator: We log the action type, action, action creator and errorResolves #127