container props and default done #229
Conversation
Did not listen to propchanges (componentWillReceiveProps). default for done was using an fat-arrow function. Accessing this in fat-arrow will bind it to the initial component. The call later to done with .call(config, ..) did nothing because it was already bound.
| getInitialState() { | ||
| config = _.defaults(config, { | ||
| // Have a default implementation of done so it can be | ||
| // called from other handlers | ||
| done: (results) => { | ||
| done: function (results) { |
There was a problem hiding this comment.
can we revert this back to the ES6 function declaration please
There was a problem hiding this comment.
we expect this to be the config object
There was a problem hiding this comment.
But it isn't. With ES6 fat arrow when you call done.call(config, results) it does not use the config as this because when getInitialState is called the function is bound to the component.
There was a problem hiding this comment.
ah, i'm an idiot. you are right. sorry!
There was a problem hiding this comment.
Its the initial component even. So if you have unmounted it and then mounted it THIS inside default done is the first now unmounted component. With the old props and such.
|
Ah yeah, I think this just got me. Had a module with |
|
@chrisbarmonde Yes =) but i didn't create multiple instances, just one that got mounted and unmounted a couple of times. I always got the same props and i passed in a callback when the callback got called it was on an old unmounted parent. But i've been wondering, if i export a container and use it multiple times on one page would it work ? Wouldn't all the components share props and such because all share same config ? |
container props and default done
|
This has been release in v0.9.2. Thanks for your help! |
Did not listen to propchanges (componentWillReceiveProps).
default for done was using an fat-arrow function. Accessing this in fat-arrow will bind it to the initial component.
The call later to done with .call(config, ..) did nothing because it was already bound.