Add initial nullability annotations #1467
Merged
+101
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasn't getting value commesurate to the extra dependencies.
php-coder
reviewed
Oct 19, 2021
| boolean seen = false; | ||
| for (Annotation annotation : declaredAnnotations) { | ||
| if (annotation.annotationType().isAssignableFrom(ParametersAreNonnullByDefault.class)) | ||
| seen = true; |
|
Just a marginalia: Projects like Jenkins have moved away from JSR 305 and use the spotbugs annotations instead. The license seems not be that clear too (see findbugsproject/findbugs#128). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using JSR-305, which IntelliJ and Kotlin and other checkers are compatible with to annotate nullability.
Includes initial annotations for ReturnsNonnull and ParametersNonnull for Jsoup.class. Over time, the goal will be to add those to all packages, and only explicitly specify nullable returns / params / fields.