Tweak formatting so that more nodes have text visible in them #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, text displayed in the node was quite wide, causing a HUGE
number of nodes to be blank (forcing use of hover text).
This commit makes more nodes have text by doing the following:
1. uses a smaller font by default for nodes
2. splits node info across 3 lines instead of 2
- function location and name are split into two lines (with parens removed)
3. tweaks text offsets to maintain vertical centering of text in the node
These tweaks still fit perfectly when rendering 20 deep.
|
Below is another example, but with depth set to 20. This is just a subsection of the overall chart. The vast majority of nodes wouldn't have any text in them without the changes in the pull request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes node text a bit smaller, with information spread across three lines rather than two. Intent being to reduce the number of empty/blank rectangles displayed.
An example subsection of what it looks likes for a few nodes is here:
Previously the second node would have been blank (and so would many more in the full chart).
More detail...
Prior to this commit, text displayed in the node was quite wide, causing a large number of nodes to be blank (forcing use of hover text).
This commit makes more nodes have text by doing the following:
These tweaks still fit perfectly when rendering 20 deep.
NOTE: This could probably have been done earlier in the code (rather than cutting up
display_namewhile generating the svg), but the end result is effective and this was quick to do. :)