-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on core-js #769
Comments
If you are using jimp for Node.js (not browser) you may try jimp-compact a repackaged version which is much smaller and also hasn't a dependency on jimp. NOTE: This is NOT an official solution. |
As far as core-js now prints a lot of spam messages through its postinstall script being a typical donationware, it is now even more reasonable to remove dependency on it: |
I can add that this ended up being a deal-breaker for me when selecting an image-processing utility for my commercial project. |
It's absolutely the same story in our project. We had to remove jimp for the same reason. |
pretty sure this was fixed with #1149 |
This is not something you should do for the user of your library, ever.
It's my job to provide your lib an environment it can run in, it's not the job of an image library to go messing with it.
Let me worry about polyfilling stuff or not polyfilling stuff. Now I have to ship core-js just to get jimp working.
Maybe have a
@jimp/polyfills
repo if you want to provide auto-polyfilling.Expected Behavior
No dependency on core-js.
Current Behavior
Jimp crashes without core-js.
Failure Information (for bugs)
Steps to Reproduce
Use jimp.
Context
My application uses jimp.
Failure Logs
The text was updated successfully, but these errors were encountered: