Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on core-js #769

Closed
laino opened this issue Aug 6, 2019 · 6 comments
Closed

Remove dependency on core-js #769

laino opened this issue Aug 6, 2019 · 6 comments
Labels
bug there is a bug in the way jimp behaves

Comments

@laino
Copy link

laino commented Aug 6, 2019

This is not something you should do for the user of your library, ever.

It's my job to provide your lib an environment it can run in, it's not the job of an image library to go messing with it.

Let me worry about polyfilling stuff or not polyfilling stuff. Now I have to ship core-js just to get jimp working.

Maybe have a @jimp/polyfills repo if you want to provide auto-polyfilling.

Expected Behavior

No dependency on core-js.

Current Behavior

Jimp crashes without core-js.

Failure Information (for bugs)

Error: Cannot find module 'core-js/modules/es6.object.define-property'
Aug 06 10:58:11 sales hub[11767]: Require stack:
Aug 06 10:58:11 sales hub[11767]: - /var/hub/node_modules/jimp/dist/index.js

Steps to Reproduce

Use jimp.

Context

My application uses jimp.

  • Jimp Version: 0.6.4
  • Operating System: Any
  • Node version: v12.7.0

Failure Logs

Error: Cannot find module 'core-js/modules/es6.object.define-property'
Aug 06 10:58:11 sales hub[11767]: Require stack:
Aug 06 10:58:11 sales hub[11767]: - /var/hub/node_modules/jimp/dist/index.js
@laino laino changed the title Remove require's referencing polyfills Remove dependency on core-js Aug 6, 2019
@pi0
Copy link

pi0 commented Aug 30, 2019

If you are using jimp for Node.js (not browser) you may try jimp-compact a repackaged version which is much smaller and also hasn't a dependency on jimp.

NOTE: This is NOT an official solution.

@hipstersmoothie
Copy link
Collaborator

@pi0 @laino PRs very welcome

@hipstersmoothie hipstersmoothie added the bug there is a bug in the way jimp behaves label Sep 3, 2019
@madconst
Copy link

As far as core-js now prints a lot of spam messages through its postinstall script being a typical donationware, it is now even more reasonable to remove dependency on it:
zloirock/core-js#548

@l1bbcsg
Copy link

l1bbcsg commented Jan 9, 2020

I can add that this ended up being a deal-breaker for me when selecting an image-processing utility for my commercial project.
Between spam, bloated size, questionable practice and "added 62 packages from 93 contributors" it's was simply not acceptable, even if jimp looked like a good choice, I'm quite disappointed in this myself.

@madconst
Copy link

madconst commented Jan 9, 2020

I can add that this ended up being a deal-breaker for me when selecting an image-processing utility for my commercial project.
Between spam, bloated size, questionable practice and "added 62 packages from 93 contributors" it's was simply not acceptable, even if jimp looked like a good choice, I'm quite disappointed in this myself.

It's absolutely the same story in our project. We had to remove jimp for the same reason.

@hipstersmoothie
Copy link
Collaborator

pretty sure this was fixed with #1149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug there is a bug in the way jimp behaves
Projects
None yet
Development

No branches or pull requests

5 participants