ref: Make ColibriSession.relayId non-nullable (avoid use of !!). #1110
+26
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
============================================
- Coverage 27.79% 27.79% -0.01%
Complexity 494 494
============================================
Files 128 128
Lines 7760 7757 -3
Branches 1097 1097
============================================
- Hits 2157 2156 -1
+ Misses 5329 5326 -3
- Partials 274 275 +1
Continue to review full report in Codecov by Sentry.
|
| if (!sessions.containsKey(session.bridge.relayId) || sessions[session.bridge.relayId] != session) { | ||
| if (!sessions.containsKey(session.bridge.jid.toString()) || | ||
| sessions[session.bridge.jid.toString()] != session | ||
| ) { | ||
| logger.info("Received a response for a session that is no longer active. Ignoring.") | ||
| return | ||
| } | ||
| // We make sure relayId is not null when there are multiple sessions. |
There was a problem hiding this comment.
This comment is no longer necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.