Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: 2.0.0 fails to start #231

Closed
monga opened this issue Apr 7, 2020 · 23 comments
Closed

Linux: 2.0.0 fails to start #231

monga opened this issue Apr 7, 2020 · 23 comments
Labels
GNU/Linux Issues affecting GNU/Linux

Comments

@monga
Copy link

monga commented Apr 7, 2020

[193209:0407/164939.241277:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_jitsi-KCGvvK/chrome-sandbox is owned by root and has mode 4755.

I was a happy user of the previous version, but now it fails with the above error.
I'm on an Debian unstable system (x86_64), with kernel 5.5.1

As a workaround, I found out (see electron/electron#17972) that

sudo sysctl kernel.unprivileged_userns_clone=1

makes it work again.

@saghul
Copy link
Member

saghul commented Apr 7, 2020

Thanks for the report!

@saghul saghul mentioned this issue Apr 7, 2020
@btlogy
Copy link

btlogy commented Apr 7, 2020

I've seen the bug while building from master yesterday.
But I was too busy getting v1.1.1 running on many devices to start digging...
Thanks to the auto-update feature, all those devices are now failing on this FATAL error after updating in the background :-/

FATAL:setuid_sandbox_host.cc(157)]` The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /tmp/.mount_jitsi-tMA386/chrome-sandbox is owned by root and has mode 4755.
Trace/breakpoint trap

I'm using mostly Debian 10 stable with kernel 4.19.98-1 and the problem persists with v2.0.0-beta2.

Thanks @monga for the workaround. 👍
It helps me too.

And thanks everyone else to be working on improving this app. 👍
Got most of my family using it since the lock down.
And the electron app is much easier and perform better than the web version.

REM: I'm getting something working on Raspbian too, but with many issues to fix (unstable cam, weird noisy sound and abi error while packaging).

@gerroon
Copy link

gerroon commented Apr 7, 2020

The thing about the work around is that you are going against the Debian's security settings. And one still needs the admin rights to get that fix.

I do hope that there is a fix with this during appimage packaging.

@saghul
Copy link
Member

saghul commented Apr 8, 2020

I could reproduce it with Ubuntu 19.10 by setting sudo sysctl kernel.unprivileged_userns_clone=0 myself, since it seems to default to 1.

Hopefully we can solve this quickly, but if anyone has ideas on how to fix it, they'd be more than welcome.

@saghul
Copy link
Member

saghul commented Apr 8, 2020

Tried to fix it on #235 and made a beta 4, but alas the problem persists :-/

@awlx
Copy link
Contributor

awlx commented Apr 8, 2020

@saghul we also saw the Problem, that's why we released the deb so People can start the stuff with --no-sandbox, which helps those people. The problem seems only to exist for Debian Buster and running everywhere without sandbox does not seem a good idea.

@gerroon
Copy link

gerroon commented Apr 8, 2020

I use other Electron apps like Trilium and Rocket.Chat, they release .deb so this is no issue

@jmcclelland
Copy link

@saghul we also saw the Problem, that's why we released the deb so People can start the stuff with --no-sandbox, which helps those people. The problem seems only to exist for Debian Buster and running everywhere without sandbox does not seem a good idea.

Where can i find the .deb file for the 2.0.0. release?

@awlx
Copy link
Contributor

awlx commented Apr 9, 2020

@saghul I can make a PR to add it if interested

We build it already and it seems to work fine:
https:/freifunkMUC/jitsi-meet-electron/releases/latest

@hex-m
Copy link

hex-m commented Apr 13, 2020

Other Electron applications have the same problem. Riot chose to set the SUID bit, Signal added --no-sandbox to their launcher.

@vladimiry
Copy link

SUID bit solution is not suitable for AppImage and Snap packages, so normally --no-sandbox gets used there (the --no-sandbox gets injected into the package, so end users don't need to do anything). Other package types can use the SUID bit scenario.

@saghul
Copy link
Member

saghul commented Apr 14, 2020

@awlx Nice! Sure thing! What approach did you follow to get it working?

@awlx
Copy link
Contributor

awlx commented Apr 14, 2020

It's to be honest pretty simple as electron-builder has a built target which is called "deb" :).

@vladimiry
Copy link

vladimiry commented Apr 14, 2020

@awlx electron-builder sets the SUID bit for the deb package but this project ships AppImage linux package only and electron-builde doesn't yet embed the --no-sandbox arg into the package of this type. So right now in the case of AppImage case I simply unpack it, apply the needed change and pack it back. I just prefer the repackaging rather than patching the electron-builder module itself as Signal does.

@saghul
Copy link
Member

saghul commented Apr 14, 2020

@awlx We don't do debs, this problem seems to manifest differently for AppImages.

@vladimiry Thanks for the insight! I think I'd go with the patching, since it's a tad simpler to maintain, at least for now.

I'll try go get a PR up later today. Thanks for the help!

saghul added a commit that referenced this issue Apr 14, 2020
saghul added a commit that referenced this issue Apr 14, 2020
@saghul
Copy link
Member

saghul commented Apr 14, 2020

I think I misread @vladimiry 's comment 🤦 I've spent some time trying to get it to work but AFAICT doing the repackage-package dance might be the only way forward, and I have no energy left for that.

At least with the current way it will work for thoe who want to create Debian packages...

@jcz1
Copy link

jcz1 commented Apr 14, 2020

I vote for debian packages :-)

@tanty
Copy link

tanty commented Apr 15, 2020

Would creating a flatpak help here?

@gregorydk
Copy link

gregorydk commented Apr 21, 2020

Would creating a flatpak help here?

Yes, flatpak always helps. Flatpak runs on all distro's, has integration for all desktops and the package can be upgraded with software center if published on Flathub.

@hferreiro
Copy link

Would creating a flatpak help here?

@tanty: https:/flathub/org.jitsi.jitsi-meet

@tanty
Copy link

tanty commented Aug 18, 2020

@gregorydk
Copy link

@hferreiro Thanks!

@saghul
Copy link
Member

saghul commented Oct 2, 2020

CLosing as this is now documented in our readme and nothing we can act upon.

@saghul saghul closed this as completed Oct 2, 2020
NeroBurner added a commit to NeroBurner/jitsi-meet-electron that referenced this issue Nov 10, 2020
Add a link to the jitsi#231 issue as searching the issue by hand is cumbersome
saghul pushed a commit that referenced this issue Nov 10, 2020
Add a link to the #231 issue as searching the issue by hand is cumbersome
csett86 added a commit to csett86/jitsi-meet-electron that referenced this issue Mar 28, 2021
csett86 added a commit to csett86/jitsi-meet-electron that referenced this issue Mar 28, 2021
csett86 added a commit to csett86/jitsi-meet-electron that referenced this issue Mar 28, 2021
Modeled after electron-userland/electron-builder#5371 (comment)
but written with promised-based fs nodejs API.

This allows to drop the app-builder-lib .desktop patch, as
--no-sandbox is now part of all linux targets via the additional launcher script,
so the arg can be dropped from the .desktop file Exec line.

Manual workaround is removed from the README as well.
csett86 added a commit to csett86/jitsi-meet-electron that referenced this issue Mar 28, 2021
Modeled after electron-userland/electron-builder#5371 (comment)
but written with promised-based fs nodejs API.

This allows to drop the app-builder-lib .desktop patch, as
--no-sandbox is now part of all linux targets via the additional launcher script,
so the arg can be dropped from the .desktop file Exec line.

Manual workaround is removed from the README as well.
saghul pushed a commit that referenced this issue Mar 30, 2021
Modeled after electron-userland/electron-builder#5371 (comment)
but written with promised-based fs nodejs API.

This allows to drop the app-builder-lib .desktop patch, as
--no-sandbox is now part of all linux targets via the additional launcher script,
so the arg can be dropped from the .desktop file Exec line.

Manual workaround is removed from the README as well.
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023
Add a link to the jitsi#231 issue as searching the issue by hand is cumbersome
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023
Modeled after electron-userland/electron-builder#5371 (comment)
but written with promised-based fs nodejs API.

This allows to drop the app-builder-lib .desktop patch, as
--no-sandbox is now part of all linux targets via the additional launcher script,
so the arg can be dropped from the .desktop file Exec line.

Manual workaround is removed from the README as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GNU/Linux Issues affecting GNU/Linux
Projects
None yet
Development

No branches or pull requests